Prevent empty nodes#17
Open
meck-gd wants to merge 3 commits intothewhiteninja:masterfrom
Open
Conversation
Draft
Contributor
Author
|
@thewhiteninja Any comments on this? I know the MR diff looks obnoxiously huge, but that's mostly because of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR changes Get-AST so it doesn't create the sort of empty nodes that would be removed later on in optimization passes anyway. Most of those nodes should be (mostly, already are) attributes instead.
The resulting XMLs are up to 15% smaller, which can make a significant difference for multi-megabyte input scripts with AST node counts in the millions.
I've repurposed the
opt_remove_empty_nodespass to makemalware2look nicer instead - in combination with the newopt_remove_nested_statement_blocks.