Tas2783a 4ch newbin1 #5569
Open
Tas2783a 4ch newbin1 #5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanhyti
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
ranj063
reviewed
Oct 25, 2025
Currently the machine driver for tas2783A can only support 2 channels. This patch adds support for 2 channel playback with 4 device setup. Signed-off-by: Niranjan H Y <[email protected]> --- v2: - commit message updated
The ACPI table has initialization data for each device which needs to be updated to device to configure the device correctly. This commit adds the change to read the entry "mipi-sdca-function-initialization-table" and update the device with the data. Signed-off-by: Niranjan H Y <[email protected]> --- v2: - update commit message description
Use fw binary parsing logic same as windows as same the same will be used in Linux Signed-off-by: Niranjan H Y <[email protected]> --- v2: - convert dbg to err log for firmware size mimatch issue - checkpatch error fix for logs - remove unwanted empty line - add software reset before fw download ASoC: tas2783A: add sw reset for firmware download
Remove unwanted initialistaion writes to the device which will now be part of the either firmware or acpi table. Signed-off-by: Niranjan H Y <[email protected]> --- v2: - update commit message
The current error message is misleading for the calib data. Fix error message to indicate that calibration data is not valid. Signed-off-by: Niranjan H Y <[email protected]> --- v2: - Update commit message
The firmware file for tas2783A contains the device and algorithm settings. So the firmware files are unique for a system and driver should have the ability to distinctly identify and pick the right firmware. This commit adds the method to uniquely identify the firmware for a system based on the below format. <Subsystem>-<Link>-<Unique>.bin * Subsystem is the PCI device subsystem-id * Link is the SoundWire link id on which the device recides. * Unique is the SoundWire slave unique id in the system. Signed-off-by: Niranjan H Y <[email protected]> --- v2: - rename get_hwid to get_pci_dev - update commit message
Add changes to support 4 tas2783A devices on mtl platform. The supported unique IDs are updated to 9, a, c, d, where c and d are configured to play left channels and 9 and a are configured to play right channel. Signed-off-by: Niranjan H Y <[email protected]> --- v2: - update commit message
niranjanhyti
force-pushed
the
tas2783a_4ch_newbin1
branch
from
e6d4b1f to
bc01d50
Compare
Collaborator
|
test this please |
bardliao
reviewed
Oct 28, 2025
| } | ||
|
|
||
| static s32 tas_get_smartamp_init_data(struct sdw_slave *peripheral, | ||
| struct tas2783_prv *tas_dev) |
Collaborator
There was a problem hiding this comment.
Can we reuse the sdca_parse_function() helper to get the init_table? What do you think? @charleskeepax
bardliao
reviewed
Oct 28, 2025
| scnprintf(tas_dev->rca_binaryname, sizeof(tas_dev->rca_binaryname), | ||
| "tas2783-%01x.bin", unique_id); | ||
| "%04X-%1X-%1X.bin", pci->subsystem_device, bus->link_id, | ||
| unique_id); |
Collaborator
There was a problem hiding this comment.
@charleskeepax submitted the Add SDCA UMP/FDL support series. Maybe you can use the FDL function, too?
Author
There was a problem hiding this comment.
@bardliao
Due to compatibility reasons with windows project, we will be using custom firmware binary file for tas2783A.
We will switch to the FDL FSM for new devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.