Skip to content

Added Revision/Version XML to bring in optional params #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prabhathn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Revision/Version XML to bring in optional params #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52f3403
Added Revision/Version XML to bring in optional params
prabhathn Oct 21, 2019
99f650a
fix for multiple addresses
prabhathn Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pyusps/address_information.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ def _create_xml(
)
)

# Documentation refers to this as "Version" - it is an option to return all optional data as well
version_el = etree.Element('Revision')
version_el.text = '1'
root.append(version_el)

for i,arg in enumerate(args):
address = arg['address']
city = arg['city']
Expand All @@ -130,7 +135,7 @@ def _create_xml(
address_extended = arg.get('address_extended', None)
firm_name = arg.get('firm_name', None)
urbanization = arg.get('urbanization', None)

address_el = etree.Element('Address', ID=str(i))
root.append(address_el)

Expand Down