Skip to content

Banch of fixes#154

Open
Serhii-Slutskyi wants to merge 7 commits into
thegamenicorus:masterfrom
Serhii-Slutskyi:master
Open

Banch of fixes#154
Serhii-Slutskyi wants to merge 7 commits into
thegamenicorus:masterfrom
Serhii-Slutskyi:master

Conversation

@Serhii-Slutskyi

@Serhii-Slutskyi Serhii-Slutskyi commented Sep 27, 2020

Copy link
Copy Markdown

I wanted to use this library, but when I installed it, I had a lot of problems

  • Picker was deprecated from react-native core repository
    This pull was fixed picker problem, and I only added to readme that picker should be installed from @react-native-community/picker

  • Some components have an issues with Maximum update depth exceeded...

to fix this issue update lib/countryPicker.js:

componentDidUpdate() {
    if(this.props.selectedCountry !== this.state.selectedCountry) {
      this.setState({
        selectedCountry: this.props.selectedCountry,
      });
    }
  }
  • Also the core ability to use of library is to use countries and get dialCode on input wasn't worked

So I reworked it, added ability to use Country code or not via prop useCountryCode

@bbaappss

Copy link
Copy Markdown

Thanks for writing this, the package it at least working now!

@ravi-poonia

Copy link
Copy Markdown

Thx man, merged it into my fork and a bunch of other PRs as well. I'm thinking of maintaining that from now on. Will you be interested in helping out?

@zizzle6717

zizzle6717 commented Dec 27, 2020

Copy link
Copy Markdown

@ravi-poonia Is your fork published? I would be happy to help out. I don't think the current maintainer will revisit this repo at all.

@zizzle6717

Copy link
Copy Markdown

I have published v1.0.0 and converted the source to typescript. Let me know if there is anything I can do to improve the change request process. Please submit new pull requests as the package as been more to https://github.com/rili-live/react-native-phone-input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants