Fix #218: restate extracted_1 with X ⊆ Λ hypothesis and prove finiteness#424
Open
Robby955 wants to merge 1 commit into
Open
Fix #218: restate extracted_1 with X ⊆ Λ hypothesis and prove finiteness#424Robby955 wants to merge 1 commit into
Robby955 wants to merge 1 commit into
Conversation
…sis and prove finiteness
Robby955
requested review from
CBirkbeck,
b-mehta,
pitmonticone,
seewoo5,
thefundamentaltheor3m and
viazovska
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted_1 was false for arbitrary X (X = univ makes X ∩ D the infinite coordinate box D, per
the #218 counterexample). This restates it with the hypothesis X ⊆ Λ and proves X ∩ D finite by intersecting with the lattice and applying ZSpan.setFinite_inter to the
bounded box D. The module builds and #print axioms extracted_1 is clean. Closes #218.