Fixes #39330 - Update bats test for removed CV/LCE activation key params#1947
Merged
zjhuntin merged 1 commit intoMay 29, 2026
Merged
Conversation
Replace deprecated --content-view and --lifecycle-environment flags with the new --content-view-environments="LCE/CV" format in hammer activation-key create. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jturel
approved these changes
May 29, 2026
Contributor
Author
|
@jturel thanks for the ack :) If you can merge, feel free (I don't seem to have access.) |
Contributor
|
Sadly I can't :( |
Member
|
@ekohl can this get a merge? |
ekohl
approved these changes
May 29, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'm looking at https://projects.theforeman.org/issues/39330 and it only refers to a Jira issue when it was deprecated. Not on my work machine so I can't view it.
So my question is whether will fail on still supported Katello versions. If so, this really deserves a version check.
Contributor
Author
|
The new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--content-viewand--lifecycle-environmentflags inhammer activation-key createwith the new--content-view-environments="LCE/CV"formatTest plan
fb-katello-contentbats pipeline and confirm the "create activation key" test passes🤖 Generated with Claude Code