Skip to content

Force FDW defaults to use undef for things that need inputs #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evgeni merged 2 commits into from
May 28, 2026
+5 −8
Merged

Force FDW defaults to use undef for things that need inputs #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5288f9d
Force FDW defaults to use undef for things that need inputs
evgeni May 27, 2026
575f403
Drop unused iop_fdw_database_password
evgeni May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/roles/iop_advisor/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@
vars:
iop_fdw_database_name: "{{ iop_advisor_database_name }}"
iop_fdw_database_user: "{{ iop_advisor_database_user }}"
iop_fdw_database_password: "{{ iop_advisor_database_password }}"
iop_fdw_remote_database_name: "{{ iop_inventory_database_name }}"
iop_fdw_remote_user: "{{ iop_inventory_database_user }}"
iop_fdw_remote_password: "{{ iop_inventory_database_password }}"
11 changes: 5 additions & 6 deletions src/roles/iop_fdw/defaults/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
---
# Required parameters - must be passed by caller
iop_fdw_database_name: ""
iop_fdw_database_user: ""
iop_fdw_database_password: ""
iop_fdw_remote_database_name: ""
iop_fdw_remote_user: ""
iop_fdw_remote_password: ""
iop_fdw_database_name: "{{ undef(hint='You must specify the FDW database name') }}"
iop_fdw_database_user: "{{ undef(hint='You must specify the FDW database user') }}"
iop_fdw_remote_database_name: "{{ undef(hint='You must specify the remote FDW database name') }}"
iop_fdw_remote_user: "{{ undef(hint='You must specify the remote FDW database user') }}"
iop_fdw_remote_password: "{{ undef(hint='You must specify the remote FDW database password') }}"

# Optional parameters - can use defaults
iop_fdw_database_host: "localhost"
Expand Down
1 change: 0 additions & 1 deletion src/roles/iop_vulnerability/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
vars:
iop_fdw_database_name: "{{ iop_vulnerability_database_name }}"
iop_fdw_database_user: "{{ iop_vulnerability_database_user }}"
iop_fdw_database_password: "{{ iop_vulnerability_database_password }}"
iop_fdw_remote_database_name: "{{ iop_inventory_database_name }}"
iop_fdw_remote_user: "{{ iop_inventory_database_user }}"
iop_fdw_remote_password: "{{ iop_inventory_database_password }}"
Expand Down