Only pass in Candlepin secrets instead of full configs#517
Draft
ekohl wants to merge 3 commits into
Draft
Conversation
This uses an updated Candlepin image that contains templates for config files and uses environment variables to provide configuration. On the Ansible side these are provided via podman secrets. This reduces the coupling between how the container is built and configured.
Member
|
From my previous testing, this strategy will not work because we have dynamic configuration. See lines: Line 29 defines the name of the prefix, and then 34-38 are what use that prefix. |
Member
Author
|
I don't quite follow. Those strings are hardcoded and theforeman/candlepin-oci-images#3 contains those exact prefixes. Note I've taken the approach of templating the entire Katello config in the container, not pass everything in via Candlepin's own env var mechanism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
This uses an updated Candlepin image that contains templates for config files and uses environment variables to provide configuration. On the Ansible side these are provided via podman secrets.
It depends on theforeman/candlepin-oci-images#3 and has a temporary commit pointing to a build.
Why are you introducing these changes? (Problem description, related links)
This reduces the coupling between how the container is built and configured. If the container is rebuilt using EL 10 and some newer Tomcat version then the server.xml may become incompatible, but the environment variables remain the same. Effectively creating an interface.
How to test this pull request
Steps to reproduce:
foremanctl deploycandlepin.serviceonly mounts in environment variables, not config filesChecklist