allow downstream product overrides for features#503
Merged
Conversation
2 tasks
evgeni
reviewed
May 13, 2026
| with features_yaml.open() as features_file: | ||
| FEATURE_MAP = yaml.safe_load(features_file) | ||
|
|
||
| # load additional feature files under features.d |
Member
There was a problem hiding this comment.
this goes beyond the "override images" that is also (differently) solved in #501, which I think can be a very valuable addition outside the image context
bochi
force-pushed
the
allow-for-downstream-configs
branch
from
9878b94 to
88fa077
Compare
bochi
changed the title
bochi
force-pushed
the
allow-for-downstream-configs
branch
from
88fa077 to
ee15b6e
Compare
evgeni
force-pushed
the
allow-for-downstream-configs
branch
from
ee15b6e to
0e50f0a
Compare
evgeni
approved these changes
May 29, 2026
Member
|
Tested this to create a Satellite-specific feature using Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
This allows downstream products to extend foremanctl without touching the actual files (features.yaml, foremanctl) As of now adding features requires patching the checkout
What are the changes introduced in this pull request?
foremanctl.py: loadsrc/features.d/*.yamlif the directory existsHow to test this pull request
Steps to test:
features.d/whatever.yamlwithfeature: { description: my_great_feature }and tryforemanctl features listOBSAH_ALLOW_EXTRA_VARS=trueand set extra vars (-e var=value) and see if they are acceptedChecklist