Speed up csv compression on SMP machines#1085
Open
sbernhard wants to merge 1 commit into
Open
Conversation
The output of pbzip2 is fully compatible with bzip2. pbzip2 is optimized on SMP machines as it splits the input in multiple chunks and uses threads to run on multiple cpu cores to speed up the compression. This change requires to add pbzip2 as a requirements in the RPM spec for foreman-maintain.
Contributor
Author
Contributor
Author
|
Thoughs on this @evgeni ? |
Contributor
Author
|
@stejskalleos can you maybe have a look at this? |
Contributor
|
/packit build |
| f.close | ||
| end | ||
| execute("bzip2 #{filepath} -c -9 > #{filepath}.bz2") | ||
| execute("pbzip2 #{filepath} -c -9 > #{filepath}.bz2") |
Contributor
There was a problem hiding this comment.
What if the pbzip2 is not available? I could not find information about where it is installed by default, so maybe some checks in place would be a good idea:
compressor = system("which pbzip2 > /dev/null 2>&1") ? "pbzip2" : "bzip2"
execute("#{compressor} #{filepath} -c -9 > #{filepath}.bz2")Second question:
By default, pbzip2 will use all available cores. This can make the Foreman instance unresponsive and can cause some access issues. Should we lower the process's priority or (somehow) limit the number of cores used for execution? So we don't exhaust the server's resources?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of pbzip2 is fully compatible with bzip2. pbzip2 is optimized on SMP machines as it splits the input in multiple chunks and uses threads to run on multiple cpu cores to speed up the compression.
This change requires to add pbzip2 as a requirements in the RPM spec for foreman-maintain.