Add a scoped search <-> patternfly chip component - #11194
Open
pcreech wants to merge 1 commit into
Open
Conversation
adamruzicka
reviewed
Aug 21, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
Would this be able to deal with complex queries containing parentheses and ors?
Member
Author
|
@adamruzicka At the moment, no. The current implementation was done as a MVP by the AI intentionally. In the added markdown file, that is spelled out as a current limitation and future improvement item. |
pcreech
added a commit
to pcreech/foreman
that referenced
this pull request
Aug 24, 2026
Addresses CI test failures in PR theforeman#11194 by resolving ESLint and Prettier violations: - Use named import for SearchChips component - Add missing ouiaId prop to ChipGroup - Fix const/let usage and variable shadowing - Apply proper code formatting and destructuring - Remove continue statement in favor of if-else All 29 tests passing with zero linting errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pcreech
force-pushed
the
react-component
branch
from
August 24, 2026 20:48
1ccb245 to
4d89a8b
Compare
Create a React component that bidirectionally converts between scoped search queries and PatternFly chip components, improving UX by providing visual representations of active search filters. This implementation includes: - ScopedSearchParser: Utility functions for parsing and converting queries - SearchChips: React component displaying filters as PatternFly chips - SearchBar integration: Automatic chip display on all table index pages - Comprehensive test coverage: 28 unit tests for parser functionality The component automatically works on any page using TableIndexPage or SearchBar, including All Hosts and Hardware Models pages (SAT-39885 MVP). Addresses JavaScript linting requirements: - Use named imports for components - Add required ouiaId props to PatternFly components - Apply proper const/let usage and code formatting - Use array destructuring patterns All tests passing with zero linting errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pcreech
force-pushed
the
react-component
branch
from
August 25, 2026 00:49
4d89a8b to
da669c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a agentic development research item, I have attempted to use Claude Code to write a component that will parameterize the scoped search query and add patternfly chips of the filter variables.