Fixes #39371 - Handle bond and VLAN interface names - #11175
Open
jakduch wants to merge 1 commit into
Open
Conversation
Restrict bond detection to numeric and hyphen-prefixed names so VLAN and alias interfaces are not converted to bonds. Restore multi-digit lagg matching and regression coverage. Assisted-By: Codex 5.6 Sol High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39371.
PR #10744 expanded the bond matcher to support hyphenated bond names, but
bond[\d-].*also classifies conventional VLAN and alias names such asbond0.601andbond0:0as bonds. The same change unintentionally narrowedlagg\d+to a single digit.As described in the community report:
Restrict bond detection to numeric
bondnames andbond-names containing letters, digits, or hyphens. This preservesbond10andbond-foo-bar, rejects VLAN and alias suffixes, and restores multi-digitlaggnames.Testing
lagg10alongside existing valid bond namesbond0.601produces aNic::Managedprimary interface instead ofNic::BondAI usage disclosure
Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an
Assisted-Bytrailer.