Skip to content

Fixes #39371 - Handle bond and VLAN interface names - #11175

Open
jakduch wants to merge 1 commit into
theforeman:developfrom
jakduch:fix/39371
Open

Fixes #39371 - Handle bond and VLAN interface names#11175
jakduch wants to merge 1 commit into
theforeman:developfrom
jakduch:fix/39371

Conversation

@jakduch

@jakduch jakduch commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #39371.

PR #10744 expanded the bond matcher to support hyphenated bond names, but bond[\d-].* also classifies conventional VLAN and alias names such as bond0.601 and bond0:0 as bonds. The same change unintentionally narrowed lagg\d+ to a single digit.

As described in the community report:

"bond0.601 is a standard name for a tagged network interface on a bond interface."

Restrict bond detection to numeric bond names and bond- names containing letters, digits, or hyphens. This preserves bond10 and bond-foo-bar, rejects VLAN and alias suffixes, and restores multi-digit lagg names.

Testing

  • Restore regression coverage for VLAN and alias names on top of bonds
  • Cover lagg10 alongside existing valid bond names
  • Verify that bond0.601 produces a Nic::Managed primary interface instead of Nic::Bond
  • Ruby syntax and standalone matcher checks pass locally

AI usage disclosure

Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an Assisted-By trailer.

Restrict bond detection to numeric and hyphen-prefixed names so VLAN and alias interfaces are not converted to bonds. Restore multi-digit lagg matching and regression coverage.

Assisted-By: Codex 5.6 Sol High
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant