Fixes #39366 - update loader from pf3 to pf5#11006
Open
andreilakatos wants to merge 1 commit into
Open
Conversation
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
from
2ee4999 to
ba2708f
Compare
Lukshio
suggested changes
May 29, 2026
Contributor
Lukshio
left a comment
Lukshio
left a comment
There was a problem hiding this comment.
Please update tests to RTL - check if component is rendered correctly for multiple sizes
andreilakatos
force-pushed
the
update-loader-to-pf5
branch
from
ba2708f to
7780eb7
Compare
Contributor
Author
Done, had to use sm instead of xs. xs no longer exists for pf5 spinner 🫤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the shared
Loadercomponent from legacy patternfly-react to PatternFly 5 (@patternfly/react-core).The spinner is used across async UI (charts, form submit states, power status, modals, etc.). This keeps loading indicators consistent with the rest of the PF5 UI and removes a dependency on the old PatternFly 3 React bindings.
Changes:
Spinnerfrompatternfly-reactwithSpinnerfrom@patternfly/react-coreloadingprop (PF5 spinners are always active)aria-label={__('Loading')}for accessibilityPurpose
Foreman is moving table and layout code to PatternFly 5. The shared
Loaderstill used patternfly-react (PF3), which produced inconsistent styling and duplicated spinner implementations. This PR updates that shared loader so pending states use the same PF5SpinnerasLoadingPage,TableIndexPage, and other PF4/PF5 surfaces.