Conversation
ofedoren
left a comment
There was a problem hiding this comment.
Thanks, @jakduch, it's a small, but a neat change :)
Although, I'd like to have another ACK from someone more UI/JS talented people.
Maybe @MariaAga have a bit of spare time to take a look? Also, could we bump the package version to a newer one? We currently use 3.3.2, whilst the latest is 13.0.0. I mean, we could probably bump few versions if latest is not compatible. There were some nice changes.
|
Thanks for the initiative! I've opened #10944 which builds on this - it bumps This PR can be closed in favor of #10944 if CI passes there, or we can keep both open and see which one gets through first. Either way, thanks for kicking this off! |
UUID v1 is timestamp-based and leaks MAC address information. UUID v4 is random-based and more appropriate for generating unique identifiers for React component keys and chart element IDs. Replace all uuid/v1 imports with uuid/v4 and rename uuidV1 variables to uuidV4 for consistency.
329ac26 to
8fe5d4f
Compare
|
Superseded by #10944, which also addresses the requested dependency upgrade and replaces the removed deep imports. |
Fixes https://projects.theforeman.org/issues/31560
Summary
UUID v1 is timestamp-based and includes MAC address information, which is unnecessary and potentially a minor privacy concern for generating React component keys and chart element IDs. UUID v4 is random-based and more appropriate for these use cases.
Changes
uuid/v1imports withuuid/v4across 8 filesuuidV1variable references touuidV4for consistencyuuid/v4No functional change — both produce valid UUIDs suitable for unique key generation.