Fix titles "by using"#3185
Merged
Merged
Conversation
maximiliankolb
approved these changes
Aug 6, 2024
Contributor
maximiliankolb
left a comment
maximiliankolb
left a comment
There was a problem hiding this comment.
diff LGTM but I am not yet familiar with the theory behind this.
Contributor
OK, understood: #3141 (comment) |
pr-processor
Bot
added
the
Waiting on contributor
Lennonka
force-pushed
the
fix-titles-by-using
branch
from
064c8cd to
157ce80
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
Contributor
Author
|
Updated the mapping file as well. |
ekohl
reviewed
Aug 6, 2024
| }, | ||
| { | ||
| "title": "Configuring Hosts Using Ansible", | ||
| "title": "Configuring Hosts by Using Ansible", |
Member
There was a problem hiding this comment.
Shouldn't this match exactly what's in guides/common/attributes-titles.adoc?
Suggested change
| "title": "Configuring Hosts by Using Ansible", | |
| "title": "Configuring hosts by using Ansible", |
Or is that something we should fix separately since it looks like all others are using title case?
ekohl
dismissed
their stale review
My concern has been addressed, but I don't have a complete picture if this wouldn't break other things right now.
Contributor
Author
|
@ekohl It will break UI links in Satellite, but that will be handled by: RedHatSatellite/foreman_theme_satellite#64 |
Lennonka
added a commit
that referenced
this pull request
Aug 7, 2024
* Fix titles - add 'by' * Shorten URL paths for updated guide titles
Contributor
Author
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please cherry-pick my commits into: