feat(provider): persist and verify exact OMP continuation sessions - #871
Open
tomdps wants to merge 3 commits into
Open
feat(provider): persist and verify exact OMP continuation sessions#871tomdps wants to merge 3 commits into
tomdps wants to merge 3 commits into
Conversation
…ontinuation sessions
tomdps
enabled auto-merge
July 31, 2026 18:43
Greptile SummaryThe PR adds exact OMP session continuation and verification.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/agent-cli-provider/adapters/omp.ts | Adds fail-closed valued-resume detection, command construction, and strict OMP session-frame inspection. |
| src/agent-cli-provider/single-agent-runtime.ts | Intersects resume feature overrides with local OMP capability detection, resolving the previously reported probing bypass. |
| task-lib/provider-session-capture.js | Applies provider-owned capture policy and persists exact identity verification or conflicts. |
| src/agent/provider-session.js | Enforces provider-specific identity normalization and completion validation before retaining resumable sessions. |
| task-lib/runner.js | Initializes tasks requiring OMP identity capture in an unverified state until watcher completion. |
| tests/unit/omp-session-lifecycle.test.js | Covers fresh capture, exact continuation, malformed or forked identities, persistence failures, retries, and durable task state. |
Sequence Diagram
sequenceDiagram
participant Agent
participant Runtime
participant OMP
participant Watcher
participant Store
Agent->>Runtime: Invoke with optional resumeSessionId
Runtime->>OMP: Probe --help
OMP-->>Runtime: Advertised CLI capabilities
alt Exact resume is locally supported
Runtime->>OMP: "--resume <sessionId>"
else Resume support is not proven
Runtime-->>Agent: Reject continuation
end
OMP-->>Watcher: JSONL session frame
Watcher->>Store: Persist captured session identity
Watcher->>Watcher: Verify required/exact identity
alt Identity is valid
Watcher-->>Agent: Completed with verified session
else Identity is missing, malformed, conflicting, or different
Watcher-->>Agent: Fail closed
end
Reviews (3): Last reviewed commit: "fix(provider): simplify OMP resume help ..." | Re-trigger Greptile
Collaborator
Author
|
Updated c07ffda closes the continuation review loop end to end:
Verification: provider build passed; 82 adapter/executable-contract tests and 43 lifecycle/capture/context/restore/reuse/task-run tests passed. Independent reviewer completed multiple reject/fix iterations and returned final APPROVE with no remaining blockers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #866