chore(cli): remove stale first-run wizard code - #861
Open
shixi-li wants to merge 1 commit into
Open
Conversation
Greptile SummaryRemoves the obsolete first-run setup wizard and aligns remaining CLI/test references with current behavior.
Confidence Score: 5/5The PR appears safe to merge because the deleted wizard has no remaining consumers and the other changes are behavior-preserving cleanup. The removed module is absent from runtime imports and package assertions,
|
| Filename | Overview |
|---|---|
| cli/index.js | Updates the global --quiet description to match its sole remaining behavior and removes a stale wizard comment. |
| cli/lib/first-run.js | Deletes an unreferenced internal wizard module with no remaining runtime importer or package-contract dependency. |
| tests/first-run.test.js | Removes tests dedicated exclusively to the deleted wizard module. |
| tests/conductor-duplicate-spawning.test.js | Removes an inert settings property while preserving the orchestration fixture behavior. |
| tests/message-buffering-while-busy.test.js | Removes an inert settings property with no effect on the tested message-buffering path. |
| tests/orchestrator-subscription-race.test.js | Removes an inert settings property with no effect on subscription-race coverage. |
| tests/package-smoke.test.js | Corrects the smoke-test title without altering package-content assertions. |
Reviews (1): Last reviewed commit: "chore(cli): remove stale first-run wizar..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli/lib/first-run.jswizard and its obsolete testfirstRunCompletefixture keys and update the stale package-smoke title--quiethelp describe the remaining update-check behaviorRelated issue
Closes #609
Scope boundary
The current
setup plan/apply/undocommands, provider detection, settings mutation, andautoCheckUpdatesbehavior remain unchanged. The eight remainingfirstRunmatches are local variables for the first invocation in two resume E2E tests, not wizard references. The only user-visible change is the corrected--quiethelp text.Testing
npm run checkpasses (TypeScript and ESLint; 0 errors)npm run build:agent-cli-providerpassesfirstRunnamesBroader local validation note:
npm testhit repository-wide orchestrator/lifecycle timing failures outside the changed paths, andnpm run check:allreached the repository's pre-existingunimportedinventory; focused tests, the isolated implicated tests, the build, type checks, and lint all pass.Breaking changes
None. The removed module had no imports, exports through the package contract, CLI entrypoint, or live call sites.