Skip to content

chore(cli): remove stale first-run wizard code - #861

Open
shixi-li wants to merge 1 commit into
the-open-engine:mainfrom
shixi-li:chore/remove-stale-first-run
Open

chore(cli): remove stale first-run wizard code#861
shixi-li wants to merge 1 commit into
the-open-engine:mainfrom
shixi-li:chore/remove-stale-first-run

Conversation

@shixi-li

Copy link
Copy Markdown
Contributor

Summary

  • remove the unused cli/lib/first-run.js wizard and its obsolete test
  • remove inert firstRunComplete fixture keys and update the stale package-smoke title
  • make --quiet help describe the remaining update-check behavior

Related issue

Closes #609

Scope boundary

The current setup plan/apply/undo commands, provider detection, settings mutation, and autoCheckUpdates behavior remain unchanged. The eight remaining firstRun matches are local variables for the first invocation in two resume E2E tests, not wizard references. The only user-visible change is the corrected --quiet help text.

Testing

  • source baseline: the exact base contained the ghost module, obsolete test, stale help, and inert fixture keys
  • 174 focused setup/settings/update-checker/CLI/package and changed-fixture tests pass on Node 20
  • 88 tests pass (1 pending) when the four project-wide failure files are isolated from suite scheduling
  • npm run check passes (TypeScript and ESLint; 0 errors)
  • npm run build:agent-cli-provider passes
  • scope guard confirms the exact seven-file diff, deleted ghost paths, no obsolete symbols, and only the eight intentional E2E firstRun names

Broader local validation note: npm test hit repository-wide orchestrator/lifecycle timing failures outside the changed paths, and npm run check:all reached the repository's pre-existing unimported inventory; focused tests, the isolated implicated tests, the build, type checks, and lint all pass.

Breaking changes

None. The removed module had no imports, exports through the package contract, CLI entrypoint, or live call sites.

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the obsolete first-run setup wizard and aligns remaining CLI/test references with current behavior.

  • Deletes the unused first-run implementation and its dedicated tests.
  • Removes inert firstRunComplete fields from isolated test settings.
  • Updates --quiet help text to describe update-check suppression accurately.
  • Refreshes the package smoke-test title without changing its assertions.

Confidence Score: 5/5

The PR appears safe to merge because the deleted wizard has no remaining consumers and the other changes are behavior-preserving cleanup.

The removed module is absent from runtime imports and package assertions, firstRunComplete has no remaining reader, and the revised --quiet text matches the existing update-check eligibility logic.

Important Files Changed

Filename Overview
cli/index.js Updates the global --quiet description to match its sole remaining behavior and removes a stale wizard comment.
cli/lib/first-run.js Deletes an unreferenced internal wizard module with no remaining runtime importer or package-contract dependency.
tests/first-run.test.js Removes tests dedicated exclusively to the deleted wizard module.
tests/conductor-duplicate-spawning.test.js Removes an inert settings property while preserving the orchestration fixture behavior.
tests/message-buffering-while-busy.test.js Removes an inert settings property with no effect on the tested message-buffering path.
tests/orchestrator-subscription-race.test.js Removes an inert settings property with no effect on subscription-race coverage.
tests/package-smoke.test.js Corrects the smoke-test title without altering package-content assertions.

Reviews (1): Last reviewed commit: "chore(cli): remove stale first-run wizar..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(cli): remove stale first-run wizard code (5/5)

1 participant