setup scheduled export of donor list#1255
Open
matthewdylan wants to merge 1 commit intofeature/donor-wallfrom
Open
setup scheduled export of donor list#1255matthewdylan wants to merge 1 commit intofeature/donor-wallfrom
matthewdylan wants to merge 1 commit intofeature/donor-wallfrom
Conversation
fillerwriter
approved these changes
Jun 30, 2025
fillerwriter
left a comment
fillerwriter
left a comment
There was a problem hiding this comment.
Assuming server.batch.charge_cards shouldn't be handled somewhere else (or is outside of this PR), this looks good to me. 👍
| # deprecated: | ||
| CELERYBEAT_SCHEDULE = { | ||
| "every-day": { | ||
| "task": "server.batch.charge_cards", |
There was a problem hiding this comment.
charge_cards seems important, but I don't know if the system is handling recurring charges through some other system outside of itself (like Stripe recurring charges or something).
Contributor
Author
There was a problem hiding this comment.
Yeah, we're good here. This is an old process that's been replaced by features within stripe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Sets up the push_donor_list function to run on a schedule determined by an env var (BATCH_HOURS)
Why are we doing this? How does it help us?
This creates an updated json file of donors for the last 365 days that we can ref instead of having to do a direct (and costly) salesforce call on the donor wall page.
How should this be manually tested?
I'll deploy this branch to staging when appropriate and test out the celery scheduling functionality (kind of hard to test that part locally).
How should this change be communicated to end users?
Doesn't need to be.
Are there any smells or added technical debt to note?
None come to mind.
What are the relevant tickets?