Restore Ordering for DependsOnGroups by using separate Priority on Configuration Methods alternative 2

[martinaldrin]

Add support for Priority in Configuration Methods and restore DependsOnGroups alternativ 2

Fixes # .

Did you remember to?

• Add test case(s)
• Update CHANGES.txt

We encourage pull requests that:

• Add new features to TestNG (or)
• Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

[martinaldrin]

The only you need to focus on when review this PR is the ClassHierarchyPriority which replace the dependsOnUpon

[Elisedlund-ericsson]

I personally prefer this alternative 2 over alternative 1 which reused the regular priority which could possibly cause issues or strange sorting for someone using the regular priority.

this alternative 2 make it very clear how it sorting

[martinaldrin]

@Elisedlund-ericsson thanks Elis, If more agree with that I will try to separate the Restore of Group sorting into a different PullRequest to separate it from the priority implementation.

[juherr]

I don't get the link between classHierarchyPriority and priority.
Where is the classHierarchyPriority set?

[martinaldrin]

@juherr classHierarchyPriority is only set in MethodInheritance
regular priority is configured by the user in the annotation.

                    m2.addMethodDependedUpon(MethodHelper.calculateMethodCanonicalName(m1));
                    if (m1.getClassHierarchyPriority() >= m2.getClassHierarchyPriority()) {
                      m2.setClassHierarchyPriority(m2.getClassHierarchyPriority() + 1);
                    }

Both of them are later used in the comparators to sort the methods in correct order.

I got the Idea about a new internal priority when I saw how "InterceptedPriority" was implemented and only used internally. Therefor I thought that this could work similar in a similar way

[juherr]

@martinaldrin Ok, I see 2 different subjects, right? Is it possible to make 2 different PR?

[juherr]

btw, I like the classHierarchyPriority idea 👍

Do you see a way to exclude it from the public API? Same remark for InterceptedPriority.

[martinaldrin]

@juherr, yes

great that you liked classHierarchyPriority!

I have following PRs that I plan to work more with:
[GITHUB-2664] Restore DependsOnGroups Behaviour. #2666
Add support for Priority in Configuration Methods #2662

#2667 and #2668 was just to show the proof of concept that it was possible to solve. So I will cancel these two and continue with the other two.

[martinaldrin]

I close this PR since it was just a Proof of Concept, will continue in #2666