Fix: alwaysRun should not force invocation of Before-methods#2198
Open
kool79 wants to merge 1 commit intotestng-team:masterfrom
Open
Fix: alwaysRun should not force invocation of Before-methods#2198kool79 wants to merge 1 commit intotestng-team:masterfrom
kool79 wants to merge 1 commit intotestng-team:masterfrom
Conversation
Member
krmahadevan
requested changes
Nov 24, 2019
Member
krmahadevan
left a comment
krmahadevan
left a comment
There was a problem hiding this comment.
There are tests that are failing in this PR. Also please help include a test.
juherr
requested changes
Nov 25, 2019
Member
juherr
left a comment
juherr
left a comment
There was a problem hiding this comment.
Could you add a non-regression test for the feature too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1622
Did you remember to?
CHANGES.txtWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.