fix: Replace ResourceOrgID with SourceOrgID #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think these conditions are all intended to check the source org ID, not the org ID of the resource.
dli-spoton
changed the title
|
Could you please provide the link to the AWS documentation pointing this out? It will help us to understand what the right value is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these conditions are all intended to check the source org ID, not the org ID of the resource.
Description
Replace
aws:ResourceOrgIDwithaws:SourceOrgIDMotivation and Context
From what I can tell, these conditions are all intended to check the source (caller) org ID, not the resource org ID.
Breaking Changes
No breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request