Offer Rename / Kill when long pressing a session in the drawer - #5264
Open
kedimuzafer wants to merge 1 commit into
Open
Offer Rename / Kill when long pressing a session in the drawer#5264kedimuzafer wants to merge 1 commit into
kedimuzafer wants to merge 1 commit into
Conversation
Long pressing a session in the drawer went straight to renaming it, so there was no way to close a session from the drawer at all. Killing one meant switching to it first and using the terminal's own context menu, or typing exit. Long press now opens a two item dialog offering Rename and Kill, with the same confirmation prompt the terminal context menu uses before killing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long pressing a session in the drawer goes straight to renaming it, so there is no way to close a
session from the drawer at all. Killing one means switching to it first and using the terminal's own
context menu, or typing
exit.This makes long press open a two item dialog offering Rename and Kill. Rename keeps the
existing behaviour; Kill reuses the same confirmation prompt (
title_confirm_kill_session) beforecalling
finishIfRunning()and removing the finished session, matching what the terminal contextmenu already does.
Two strings are added for the menu items and one for the confirmation.
Tested on an Android 16 device and an API 31 emulator: renaming still works, killing removes the
session from the drawer list, and cancelling leaves it running.