Skip to content

Add LastPendingIntentRequestCode support to TermuxAPIAppSharedPreferences#3043

Merged
agnostic-apollo merged 1 commit intotermux:masterfrom
EduardDurech:master
Oct 13, 2022
Merged

Add LastPendingIntentRequestCode support to TermuxAPIAppSharedPreferences#3043
agnostic-apollo merged 1 commit intotermux:masterfrom
EduardDurech:master

Conversation

@EduardDurech
Copy link
Copy Markdown
Contributor

@EduardDurech EduardDurech commented Oct 12, 2022

@agnostic-apollo
Copy link
Copy Markdown
Member

Enabled commitToFile. Also ideally pull requests shouldn't be sent from the master branch, create separate branche for each pull, useful if multiple pull requests need to be sent and you won't have to force push master branch on your repo after merging and can just delete pull branch.

@agnostic-apollo
Copy link
Copy Markdown
Member

Also ideally constant should have been added to TermuxPreferenceConstants javadoc changelog due to some old convention I keep on using. I didn't do it currently cause it would have broken multiple commits on my local repo.

@EduardDurech
Copy link
Copy Markdown
Contributor Author

Also ideally pull requests shouldn't be sent from the master branch, create separate branche for each pull, useful if multiple pull requests need to be sent and you won't have to force push master branch on your repo after merging and can just delete pull branch.

Okay, will keep in mind, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants