Merged
Conversation
cchatzis
changed the title
blzserdos
reviewed
Nov 25, 2025
Contributor
Author
|
Hi, I updated the example following the revision. Let me know what you think! |
MarieRoald
requested changes
Dec 21, 2025
Collaborator
MarieRoald
left a comment
MarieRoald
left a comment
There was a problem hiding this comment.
This looks really good, just a couple of small details to consider :)
Collaborator
|
I updated the CI/CD-pipeline since the Python version (and dependencies) we ran with before were old. Merging |
Contributor
Author
|
Thank you for taking the time to review this thoroughly and for the nice comments. Let me know if anything else is required before merging :) |
Collaborator
|
Great work! Merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as mentioned in #23, here is an example notebook with the replicability check approach for selecting the number of components.
Kindly let me know what you think.