test: reject empty challenge ids during formatting#38
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9893411ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "tests": { | ||
| "format": { | ||
| "success": false, | ||
| "error_type": "format_error" | ||
| } |
There was a problem hiding this comment.
When this vector file changes, select_ci_adapters.py treats conformance/vectors/** as shared and runs all adapters, and .github/workflows/conformance.yml:126-134 invokes vector_runner.py --adapter "$ADAPTER" as a required step. The current diff does not update the pinned TypeScript SDK (conformance/package.json:19-20, mppx 0.7.0), and this new expectation is known to fail against that pin, so merging it will make conformance CI fail on every PR/push until the adapter/dependency is updated or the case is temporarily gated.
Useful? React with 👍 / 👎.
1 participant
Summary
www-authenticateconformance vector for rejecting a challenge object withid: ""during formatting/construction.error_empty_id, so parse and format expectations now agree.This follows #19 (comment).
Verification
python3 -m json.tool conformance/vectors/www-authenticate.jsongit diff --checkpython3 scripts/vector_runner.py --adapter typescript --vector www-authenticate --verbosecurrently reports 37 passed, 1 failed: the newerror_empty_id_formatcase fails against pinnedmppx@0.7.0, as expected until the mppx fix is released/consumed.