test: add M7 header escaping conformance#16
Merged
Conversation
mablr
reviewed
Jun 18, 2026
Comment on lines
+514
to
+516
| if (value.indexOf('\r') >= 0 || value.indexOf('\n') >= 0) { | ||
| throw new IllegalArgumentException("Header values must not contain CR or LF"); | ||
| } |
Contributor
There was a problem hiding this comment.
This CRLF guard seems to be only exercised when formatChallenge takes the opaque-present manual formatting path. The new CRLF vector omits opaque, so Java returns through challenge.toWwwAuthenticate() and CI would still pass if this quote() guard regressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blocked on mpp-java release.