Respect SDK flags in history & gzip downgrade#1370
Merged
Conversation
tconley1428
approved these changes
Jul 1, 2026
Member
Author
|
@claude review |
chris-olszewski
approved these changes
Jul 2, 2026
Comment on lines
+116
to
+117
| CompressionTestBehavior::GenericGzipUnimplemented | ||
| if path.ends_with("/GetSystemInfo") => |
Member
There was a problem hiding this comment.
Should this only be hit if gzip is being used?
Suggested change
| CompressionTestBehavior::GenericGzipUnimplemented | |
| if path.ends_with("/GetSystemInfo") => | |
| CompressionTestBehavior::GenericGzipUnimplemented | |
| if path.ends_with("/GetSystemInfo") && encoding == "gzip" => |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Title
Why?
If
GetSystemInforeturnsUNIMPLEMENTEDfor whatever reason (recent ex: gzip compression not working specifically for this endpoint), then we will fail to respect flags already written into history. Fix that.Additionally allow downgrading to not using compression if a the GSI RPC fails on startup
Checklist
Closes
How was this tested:
Upgrade existing tests and added new ones
Any docs updates needed?