Update contributing guide#1625
Draft
tconley1428 wants to merge 7 commits into
Draft
Conversation
Sushisource
reviewed
Jun 29, 2026
tconley1428
commented
Jul 1, 2026
|
|
||
| Maintainers review pull requests for correctness, compatibility, test coverage, | ||
| documentation, and long-term maintainability. Review may require changes before a | ||
| pull request can be merged. |
Contributor
Author
There was a problem hiding this comment.
Add that it may take some time to review depending on workload.
tconley1428
commented
Jul 1, 2026
Sushisource
reviewed
Jul 2, 2026
| * Avoid broad refactors, style churn, or unrelated cleanups in behavior changes. | ||
| * Avoid unqualified imports from `temporalio` packages except `temporalio.types`. | ||
| Relative imports are acceptable for private packages. | ||
| * Do not commit `uv.lock` or `pyproject.toml` changes created only for temporary |
Member
There was a problem hiding this comment.
I would say it should prefer to just use the docker command
Co-authored-by: Spencer Judge <sjudge@hey.com>
Co-authored-by: Spencer Judge <sjudge@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing