[SDK Sentinel] Deflake Dataflow workflow scheduler test - #854
Open
sdk-sentinel-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Deflakes the standard-library workflow test after a [Windows test failure](https://github.com/temporalio/sdk-dotnet/actions/runs/32283704948/job/96168122371). The [last known good run](https://github.com/temporalio/sdk-dotnet/actions/runs/32283537962) immediately preceded the [first known bad run](https://github.com/temporalio/sdk-dotnet/actions/runs/32283704948), and the following run passed.
Root cause
The Dataflow case sent to an empty
BufferBlockbefore registering its receive. The send could buffer while the Default-scheduler offer was deferred, allowing the workflow deadlock detector to become the last failure before the expected scheduler violation.Fix
Register
ReceiveAsyncbeforeSendAsync. This makes the send immediately exercise the prohibited off-workflow scheduling and removes the ordering race.Validation
The focused test passed 10/10 after the change; five pre-change Linux attempts did not reproduce. The trusted baseline passed. Candidate validation reached build but was blocked by inherited
objtimestamp permissions, so clean validation and the Windows x64 CI job remain required.Validation status:
validation-incompletehighmediummediumstandard— 1 changed file; 1002 Bnot-reproduced— Five focused pre-change Linux attempts passed; bounded Windows CI remains the natural occurrence.pass-after-only— The existing focused test passed 10 times after the ordering change and consistently exercised the intended Dataflow scheduler violation.dotnet format and build) — passeddotnet format and build) — did not pass (failure)Investigator-run checks
dotnet run --project tests/Temporalio.Tests -- -verbose -method "*.ExecuteWorkflowAsync_StandardLibraryCalls_FailsTaskWhenInvalid"— passed; 5 attempt(s). Five pre-change Linux attempts passed; the natural Windows occurrence did not reproduce.dotnet run --project tests/Temporalio.Tests -- -verbose -method "*.ExecuteWorkflowAsync_StandardLibraryCalls_FailsTaskWhenInvalid"— passed; 10 attempt(s). All 10 post-change Linux attempts passed and logged the expected Dataflow invalid-scheduler failure..ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). Formatting completed, but build failed with MSB3374 access-denied errors while touching inherited obj/*.Up2Date files; no source or analyzer failure was reported.Trusted unchanged-checkout baseline validation— passed; 1 attempt(s). The workflow-recorded baseline build passed with zero warnings and errors.Required target CI
Residual risks
Automation provenance
dcf7ca3f4fc230315c6f518e3f3c1a1f52670963If this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-08-19 18:11 UTC2026-08-19 18:11 UTC