Adding SDK Ergonomics Query link - #825
Conversation
119c340 to
e9b047f
Compare
jmaeagle99
left a comment
jmaeagle99
left a comment
There was a problem hiding this comment.
The PR description says "Queries now have a backlink.", but that's just one of three changes in this PR. There's also the URL format change and the error mapping change. Not sure they really are tied to the support for query backlinks. Might have made it faster to review if they were separate (if they truly are disconnected) so I didn't have to figure out that delineation. This will also make it harder to look back into history to discover which change was responsible for one of these three aspects.
25b1053 to
7140f41
Compare
| Assert.Equal(HandlerErrorType.NotImplemented, exc3.ErrorType); | ||
| Assert.Equal("Intentional failure", exc3.Message); | ||
| var chainMessages = new List<string>(); | ||
| for (Exception? cause = exc; cause != null; cause = cause.InnerException) |
There was a problem hiding this comment.
Looked into this more. The top level exception of exc3 used to be a HandlerException with message "Intentional failure". But now it's a HandlerException with message "" with an inner exception of type HandlerException with message "Intentional failure". I think this needs to be investigated as to why this is happening because that's a behavior change to an existing feature that I believe is now GA.
2 participants
Queries now have a backlink.