Add system Nexus signal-with-start workflow API#744
Open
tconley1428 wants to merge 12 commits into
Open
Conversation
tconley1428
commented
Jun 16, 2026
…with-start # Conflicts: # tests/Temporalio.Tests/WorkflowEnvironment.cs
jmaeagle99
reviewed
Jun 22, 2026
| }); | ||
| } | ||
|
|
||
| static void GeneratePayloadVisitorRegistry(string operationsPath, string descriptorPath) |
Contributor
There was a problem hiding this comment.
I'm slightly concerned about the fragility of this. It uses regex on the C# output from the nex-gen call, the message structure from the proto descriptors, and does some kind of fuzzy-ish join on the two. A couple of things:
- Can we have nex-gen emit the operation to message mapping as some kind of structured data and read that instead?
- Can this project be refactored a bit to be testable? It would be good to have this generator be testable and to add tests for the generated payload visitor.
Contributor
Author
There was a problem hiding this comment.
We talked about this. I think we're going to replace it with a more generic payload visitor soon as needed for external storage and that should replace this brittle generator.
jmaeagle99
reviewed
Jun 25, 2026
jmaeagle99
left a comment
Contributor
There was a problem hiding this comment.
I would ask that the ExpressionUtil forward and marking public methods / types as experimental are done before merging. Adding GeneratedCode attribute would be nice, but can be deferred.
jmaeagle99
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing