Skip to content

Fix ILDGCheckpointer bug when saving smeared cfgs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gray95 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix ILDGCheckpointer bug when saving smeared cfgs #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08be252
expose gauge group from GImpl
vataspro Apr 15, 2026
7f3f5f6
bugfix: ILDGCheckpointer was saving unsmeared cfgs to smr_prefix
gray95 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Grid/qcd/action/gauge/GaugeImplTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ template <class S, int Nrepresentation = Nc, int Nexp = 12, class Group = SU<Nc>
typedef Lattice<SiteLink> LinkField;
typedef Lattice<SiteField> Field;

typedef Group GaugeGroup;

// Guido: we can probably separate the types from the HMC functions
// this will create 2 kind of implementations
// probably confusing the users
Expand Down
63 changes: 31 additions & 32 deletions Grid/qcd/hmc/checkpointers/ILDGCheckpointer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,39 +85,40 @@ class ILDGHmcCheckpointer : public BaseHmcCheckpointer<Implementation> {
// template arguments to IldgWriter
void chooseIldgWriter( std::string format, std::string group, bool reduced_matrix,
std::string lat_obj, int traj,
ConfigurationBase<GaugeField> &SmartConfig) {
ConfigurationBase<GaugeField> &SmartConfig,
bool smeared ) {

GridBase *grid = SmartConfig.get_U(false).Grid();
GridBase *grid = SmartConfig.get_U(smeared).Grid();

IldgWriter _IldgWriter(grid->IsBoss());
_IldgWriter.open(lat_obj);

if(format=="IEEE64BIG") {
if(group=="su" && reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::REDUCED, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::REDUCED, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
else if (group=="su" && !reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::FULL, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::FULL, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
else if (group=="sp" && reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::REDUCED, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::REDUCED, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
else if (group=="sp" && !reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::FULL, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::FULL, FloatingPointFormat::IEEE64BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
}
else if (format=="IEEE32BIG") {
if(group=="su" && reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::REDUCED, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::REDUCED, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
else if (group=="su" && !reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::FULL, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::SU, MatrixFormat::FULL, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
else if (group=="sp" && reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::REDUCED, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::REDUCED, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
else if (group=="sp" && !reduced_matrix) {
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::FULL, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(false), traj, lat_obj, lat_obj);
_IldgWriter.writeConfiguration<GaugeStats, GroupName::Sp, MatrixFormat::FULL, FloatingPointFormat::IEEE32BIG>(SmartConfig.get_U(smeared), traj, lat_obj, lat_obj);
}
}

Expand All @@ -136,33 +137,31 @@ class ILDGHmcCheckpointer : public BaseHmcCheckpointer<Implementation> {
BinaryIO::writeRNG(sRNG, pRNG, rng, 0,nersc_csum,scidac_csuma,scidac_csumb);
std::cout << GridLogMessage << "Written BINARY RNG " << rng
<< " checksum " << std::hex
<< nersc_csum<<"/"
<< scidac_csuma<<"/"
<< scidac_csumb
<< std::dec << std::endl;

chooseIldgWriter( Params.format, Params.group, Params.reduced_matrix, config, traj,
SmartConfig );

std::cout << GridLogMessage << "Written ILDG Configuration on " << config
<< " checksum " << std::hex
<< nersc_csum<<"/"
<< scidac_csuma<<"/"
<< scidac_csumb
<< std::dec << std::endl;

if ( Params.saveSmeared ) {
chooseIldgWriter( Params.format, Params.group, Params.reduced_matrix, smr, traj,
SmartConfig );

<< nersc_csum<<"/"
<< scidac_csuma<<"/"
<< scidac_csumb
<< std::dec << std::endl;

chooseIldgWriter(Params.format, Params.group, Params.reduced_matrix, config, traj,
SmartConfig, false);

std::cout << GridLogMessage << "Written ILDG Configuration on " << config
<< " checksum " << std::hex
<< nersc_csum<<"/"
<< scidac_csuma<<"/"
<< scidac_csumb
<< std::dec << std::endl;

if ( Params.saveSmeared ) {
chooseIldgWriter(Params.format, Params.group, Params.reduced_matrix, smr, traj,
SmartConfig, true);
std::cout << GridLogMessage << "Written ILDG Configuration on " << smr
<< " checksum " << std::hex
<< " checksum " << std::hex
<< nersc_csum<<"/"
<< scidac_csuma<<"/"
<< scidac_csumb
<< std::dec << std::endl;
}

}
};

Expand All @@ -188,7 +187,7 @@ class ILDGHmcCheckpointer : public BaseHmcCheckpointer<Implementation> {
_IldgReader.close();

std::cout << GridLogMessage << "Read ILDG Configuration from " << config
<< " checksum " << std::hex
<< " checksum " << std::hex
<< nersc_csum<<"/"
<< scidac_csuma<<"/"
<< scidac_csumb
Expand Down
Loading