Skip to content

Issue #000000 Fix: Fix about cohort member API response code and error message #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaibhavsTekdi wants to merge 2 commits into
base: aspire-leaders
Choose a base branch
from
Open

Issue #000000 Fix: Fix about cohort member API response code and error message #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52f1f2a
Issue #000000 Fix: Fix about cohort member API response code and erro…
vaibhavsTekdi Oct 6, 2025
f3c3c93
Merge remote-tracking branch 'upstream/aspire-leaders' into vs-fixes
vaibhavsTekdi Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/adapters/postgres/cohortMembers-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,9 @@ export class PostgresCohortMembersService {
return APIResponse.error(
res,
apiId,
API_RESPONSES.USER_NOTFOUND,
API_RESPONSES.USER_NOT_MEMBER_OF_COHORT,
API_RESPONSES.NOT_FOUND,
HttpStatus.OK
HttpStatus.NOT_FOUND
Comment thread
vaibhavsTekdi marked this conversation as resolved.
);
}
userYearExistInYear = getYearExitUser.map(
Expand Down
1 change: 1 addition & 0 deletions src/common/utils/response.messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const API_RESPONSES = {
TENANT_ID_NOTFOUND: '"Invalid input: TenantId must be a valid UUID."',
COHORT_NOTFOUND: 'Cohort not exist for this year.',
USER_NOTFOUND: 'User not exist for this year.',
USER_NOT_MEMBER_OF_COHORT: 'User is not a member of any cohort',
USER_DETAIL_NOTFOUND: 'User details not found',
COHORT_GET_SUCCESSFULLY: 'Cohort members details fetched successfully.',
COHORT_USER_NOTFOUND: 'User not exist in this cohort for this year.',
Expand Down