Skip to content

[nonextensible-applies-to-private] fix #4587 bugs #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[nonextensible-applies-to-private] fix #4587 bugs #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb9fe9b
[nonextensible-applies-to-private] fix #4587 bugs
erights Sep 30, 2025
cd4dd10
return override alway use public static method
erights Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/language/statements/class/elements/private-class-field-on-nonextensible-objects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class ClassWithPrivateAccessor extends NonExtensibleBase {

const a = new ClassWithPrivateAccessor(false);
// extensible objects can be extended
assert.sameValue(m.publicAccessor, 42);
assert.sameValue(a.publicAccessor, 42);

// where superclass prevented extensions & subclass extended
assert.throws(TypeError, function () {
Expand Down
20 changes: 9 additions & 11 deletions ...anguage/statements/class/subclass/private-class-field-on-nonextensible-return-override.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ class ClassWithPrivateField extends TrojanBase {
super(obj);
this.#val = 42;
}
val() {
return this.#val;
static val(obj) {
return obj.#val;
}
}

const t = new ClassWithPrivateField({});
// extensible objects can be extended
assert.sameValue(t.val(), 42);
assert.sameValue(ClassWithPrivateField.val(t), 42);

// where superclass prevented extensions & subclass extended
assert.throws(TypeError, function () {
Expand All @@ -59,15 +59,14 @@ class ClassWithPrivateMethod extends TrojanBase {
#privateMethod() {
return 42;
};
// public methods are on the prototype, so are ok.
publicMethod() {
return this.#privateMethod();
static val(obj) {
return obj.#privateMethod();
}
}

const m = new ClassWithPrivateMethod({});
// extensible objects can be extended
assert.sameValue(m.publicMethod(), 42);
assert.sameValue(ClassWithPrivateMethod.val(m), 42);

// where superclass prevented extensions & subclass extended
assert.throws(TypeError, function () {
Expand All @@ -84,15 +83,14 @@ class ClassWithPrivateAccessor extends TrojanBase {
get #privateAccessor() {
return 42;
};
// public accessors are on the prototype, so are ok.
get publicAccessor() {
return this.#privateAccessor;
static val(obj) {
return obj.#privateAccessor;
}
}

const a = new ClassWithPrivateAccessor({});
// extensible objects can be extended
assert.sameValue(m.publicAccessor, 42);
assert.sameValue(ClassWithPrivateAccessor.val(a), 42);

// where superclass prevented extensions & subclass extended
assert.throws(TypeError, function () {
Expand Down