Add convention around asserts and make it clear that grammars are con… #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…text-sensitive.
While working on the proposal-scopes branch and the decoding of scope information, I was contemplating how we could keep the algorithms somewhat readable while also accounting for malformed source maps without having to sprinkle "if condition, optionally report an error" everywhere.
As such I suggest the following:
As an example, I'd find the former much easier to read then the latter:
versus
IMO we are specifying a wire format and not a programming language. I eluded to this in the scopes meeting that we shouldn't tailor the specification text so an engineer can follow it line-by-line and implement it, but rather to convey how the format works.
Just a proposal though. If folks feel strongly about keeping it as-is and trying to spell out how to handle the context-sensitive aspects of the grammar in the decoding steps, then we can do that as well :)