Fix failed VIES calls since Oct 28th 2021#7
Open
berislavbabic wants to merge 1 commit into
Open
Conversation
VIES calls started failing with this gem around October 28th. We traced the issue back to the SOAPAction key being included in the request header. Here is a quick fix to exclude the offending header. For search purposes, the error we got was: "Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."
|
Looking good from our end, would be great if someone could merge this :) |
|
@fastdivision Could we merge this? Looks good from our end and would fix the error that makes the gem unusable now :) |
|
@fastdivision I'd really like to have this in a new release. Is there anything I can do to help move this forward? |
|
@berislavbabic any chance you could sign that CLA so @fastdivision or someone else at TaxJar can merge this? |
Author
|
@mvz sorry I missed this notification. It's now signed |
|
Thanks, @berislavbabic! |
Author
|
@fastdivision can we get this merged please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIES calls started failing with this gem around October 28th. We traced
the issue back to the SOAPAction key being included in the request
header. Here is a quick fix to exclude the offending header.
For search purposes, the error we got was:
"Unknown error: (soap:Server) The given SOAPAction checkVat does not match an operation."
Before this fix:
After the fix: