feat(webview-window): add set_simple_fullscreen to WebviewWindow #14619
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Package Changes Through eb38850There are 3 changes which include tauri-macos-sign with patch, tauri-bundler with patch, tauri with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
approved these changes
Dec 7, 2025
Contributor
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Looks great, thanks! Just some nitpicks and just to let to know that we'll probably delay merging this for a bit to see if we want to publish any patch releases at the mean time
| /// - **Other platforms:** Falls back to [`Self::set_fullscreen`]. | ||
| #[cfg(target_os = "macos")] | ||
| pub fn set_simple_fullscreen(&self, fullscreen: bool) -> crate::Result<()> { | ||
| self.window.set_simple_fullscreen(fullscreen) |
Contributor
There was a problem hiding this comment.
Since we handle this in set_simple_fullscreen anyways, I think we just use a single function here that does the forwarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13670