Add tests for new Stream and ConsumersManager methods from PR #33#34
Merged
s3rius merged 1 commit intofeature/missing-apisfrom Mar 26, 2026
Merged
Conversation
…es in js.py Agent-Logs-Url: https://github.com/taskiq-python/natsrpy/sessions/86c923dd-8c47-4c2d-9068-513eedfff7db Co-authored-by: s3rius <18153319+s3rius@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
s3rius
March 26, 2026 16:37
View session
s3rius
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the new API surface added in #33: direct subject access methods on
Stream,delete_message, and consumer listing viaConsumersManager.New tests (
python/tests/test_stream_new_methods.py)direct_get_next_for_subject— with and withoutsequenceparameterdirect_get_first_for_subject/direct_get_last_for_subject— verifies correct message selectiondelete_message— confirms message count decreases after deletionConsumersManager.list— iteration count, correctPullConsumer/PushConsumertype discrimination, empty streamConsumersManager.list_names— name matching, empty streamPublic API exports (
python/natsrpy/js.py)ConsumersIteratorandConsumersNamesIteratorto imports and__all__These types were defined in
managers.pyiand registered in the Rust module but not re-exported from the Python package.