Add test coverage and docstrings for counters module#31
Merged
Conversation
…ersManager.update stub type Co-authored-by: s3rius <18153319+s3rius@users.noreply.github.com> Agent-Logs-Url: https://github.com/taskiq-python/natsrpy/sessions/2733a833-233b-4952-805d-165167131405
Copilot created this pull request from a session on behalf of
s3rius
March 26, 2026 12:39
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counters module had zero test coverage and missing docstrings on
CounterEntry,Counters, and allCountersmethods.Tests (
python/tests/test_counters.py)add,incr,decr,getincluding negative values, multiple increments, mixed incr/decr, separate subjectsDocstrings (
counters.pyi)CounterEntryandCountersadd,incr,decr,getwith param/return/raisesStub fix (
managers.pyi)CountersManager.update()parameter type corrected fromCountersConfig→StreamConfigto match the Rust implementation, which acceptsStreamConfig:Note: callers must set
allow_direct=Trueandallow_message_counter=Trueon theStreamConfigto avoid NATS rejecting the update.