Skip to content

Complete user registration integration tests Riko, Andreas#32

Closed
Riks69 wants to merge 1 commit intotanjaq:mainfrom
Riks69:main
Closed

Complete user registration integration tests Riko, Andreas#32
Riks69 wants to merge 1 commit intotanjaq:mainfrom
Riks69:main

Conversation

@Riks69
Copy link
Copy Markdown

@Riks69 Riks69 commented Mar 29, 2026

Integration Tests for User Registration System

Ülesanne 1: API testid (app.test.js)

  • 61 testi, kõik läbivad
  • Jooksuaeg: 98 ms
  • Coverage: 100%

Ülesanne 2: Mocked API testid (app.mock.test.js)

  • Identsed testid mokeeritud emaili valideerimisega
  • Jooksuaeg: 91 ms (7% kiirem)
  • Coverage: 100%

Business requirements verified:

  • Username: 6-30 chars, letters/numbers/periods only
  • Password: 8+ chars, uppercase, lowercase, number, no special chars
  • Email: valid format with @ and valid domain extension

Performance comparison:
Mocked tests are ~7% faster than regular API tests

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

API & Mocked Tests and Coverage

Purpose: Validate README requirements for regular tests, mocked email tests, coverage, and runtime comparison.
Status: ❌ FAIL
Regular tests (app.test.js): ✅ PASS (1432ms)
Mocked tests (app.mock.test.js): ✅ PASS (1290ms)
Coverage gate (both runs at 100%): ✅ PASS
Runtime gate (regular ≥ mocked + 1500ms): ❌ FAIL
Regular coverage (app.js): lines=100% | statements=100% | functions=100% | branches=100%
Mocked coverage (app.js only): lines=100% | statements=100% | functions=100% | branches=100%
Run details: https://github.com/tanjaq/User-Register/actions/runs/23716177856
PR checks: https://github.com/tanjaq/User-Register/pull/32/checks
Where to look: Inspect the Run regular tests, Run mocked email tests, Enforce 100% coverage, and Enforce runtime rule step logs in this run.

@tanjaq tanjaq added grade enhancement New feature or request and removed grade enhancement New feature or request labels Mar 29, 2026
@tanjaq
Copy link
Copy Markdown
Owner

tanjaq commented Mar 30, 2026

@Riks69
Esiteks, see ei olnud paaristöö (teie puhul kolmene grupp, koos AI-ga).
Lisaks on ülesanne lugemata, validateEmail-i ei tohtinud muuta, ainult teste.

@tanjaq tanjaq closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants