Open
Conversation
Contributor
jimmybot
commented
Dec 28, 2022
jimmybot
commented
Plug.Conn has a special key host that is used to store host information instead of relying on the list of headers. In newer versions of Plug.Conn, it raises an error if put_req_header is used to set host to prevent this mistake. Read host from the right place and update tests.
…1.10 Fix credo issue: Enum.map |> Enum.join now Enum.map_join
reverse_proxy_plug currently maps url paths so that the original directory at which the route is mounted is not passed over to the destination server This new option preserve_request_path allows for the original directory to be passed back so that the destination server receives the full original request path For example, if the option is set to true and ReverseProxyPlug were mounted at a route '/abc' and a request came in as '/abc/123', the destination server would be requested '/abc/123' and not '/123'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.