feat: bridge short silence gaps in pre-roll to capture plosive onsets - #45
Merged
Conversation
…nsets Words beginning with a brief plosive burst followed by a sub-silence gap (e.g. Japanese "kitto" with geminate consonant "っ") were losing their initial fragment because findPreRollStartFrame stopped at the first below-threshold chunk. The backward scan now tracks consecutive silence duration and only terminates when the gap exceeds 200ms, bridging brief intra-word silences like geminate consonants and stop consonant releases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findPreRollStartFrame()so the backward scan bridges brief intra-word silences (geminate consonants, stop consonant releases) instead of treating them as the pre-speech boundaryTest plan
pnpm typecheckpassespnpm lintpasses (no new warnings)pnpm test:cipasses — all 116 tests including 2 new ones🤖 Generated with Claude Code