fix: prevent segfault in copyToChannel on Android - #44
Merged
Conversation
…efore copy Compute buffer size from actual chunk data instead of trusting bufferedFramesRef, merge all chunks into a single Float32Array, and make one copyToChannel call. This eliminates the offset-tracking loop where a mismatch could cause an out-of-bounds native memcpy. Also enables Sentry tombstone collection for richer Android NDK crash reports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioBufferHostObject::copyToChannelon Android by computing buffer size from actual chunk data (notbufferedFramesRef) and merging all chunks into a singleFloat32Arraybefore a singlecopyToChannelcall — eliminates the offset-tracking loop where a size mismatch could cause an out-of-bounds nativememcpyvoiceStartSecsto non-negative to prevent invalid playback offsets if frame accounting driftsenableTombstonefor richer Android NDK crash reports with thread info and better stack tracesTest plan
pnpm typecheckpassespnpm lintpasses (no new warnings)pnpm test:cipasses (114 tests)🤖 Generated with Claude Code