Serde support for serializing and deserializing binary blobs in XML files #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reading the config to determine trimming options.
Mingun
reviewed
Jul 22, 2024
Comment on lines
2247
to
2256
| match e | ||
| .unescape_with(|entity| self.entity_resolver.resolve(entity)) | ||
| .map(|res| self.drain_text(res)) | ||
| { | ||
| Ok(x) => x, | ||
| // failed to escape treat as binary blob. | ||
| Err(_) => Ok(DeEvent::Binary(Binary { | ||
| text: e.into_inner(), | ||
| })), | ||
| } |
There was a problem hiding this comment.
We definitely shouldn't rely on luck here. Binary should be explicitly requested for the field via flag in field name
There was a problem hiding this comment.
What is the best way/mechanism to maintain context in the code to keep track of flags like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to support binary blobs in serde, needed for vtkio.
This attempts to address #623
While initial support was added #783 this adds it for the serde api.
This PR also adjusts how trimming is handled in the serde API since this is important when dealing with binary. I tried to be consistent with the event based Reader/Writer APIs.
Please inspect the test failures to evaluate if this makes sense.