feature [8.4][bcmath] implement bcround, bcceil and bcfloor #546
+1,198
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 20, 2025
Dean151
force-pushed
the
feat/bcceil-bcfloor-bcround
branch
5 times, most recently
from
394b10a to
dd5eded
Compare
|
|
||
| if (\PHP_VERSION_ID < 80400) { | ||
| // @author Thomas Durand <[email protected]> | ||
| final class RoundingMode { |
There was a problem hiding this comment.
when PHP >= 8.1 is used, we should use a real enum
There was a problem hiding this comment.
@nicolas-grekas When I try to introduce an enum, even behind an if PHP_VERSION_ID, older PHP version are complaining pretty badly on the syntax.
See this CI run
An idea?
Dean151
force-pushed
the
feat/bcceil-bcfloor-bcround
branch
3 times, most recently
from
2f04391 to
41c0a15
Compare
Dean151
force-pushed
the
feat/bcceil-bcfloor-bcround
branch
from
41c0a15 to
8453863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcround,bcfloorandbcceilpolyfills