Skip to content
This repository was archived by the owner on Jun 10, 2022. It is now read-only.

fix: removed decoded address#683

Open
AnthonyLaw wants to merge 2 commits into
devfrom
convert-to-encoded-address
Open

fix: removed decoded address#683
AnthonyLaw wants to merge 2 commits into
devfrom
convert-to-encoded-address

Conversation

@AnthonyLaw

@AnthonyLaw AnthonyLaw commented Jan 6, 2022

Copy link
Copy Markdown
Member

Current behavior

  • All the addresses in the REST response are in decoded format.
  • Example 98E0D138EAF2AC342C015FF0B631EC3622E8AFFA04BFCC56

What was the issue?

  • Decoded address format is not user-friendly. We have feedback from the community and discussion, change the address to encoded format.
  • Example TDQNCOHK6KWDILABL7YLMMPMGYRORL72AS74YVQ

What's the fix?

  • Convert addresses from decoded to encoded (base32) format.
  • updated unit test

@sonarqubecloud

sonarqubecloud Bot commented Jan 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@0x6861746366574

Copy link
Copy Markdown

@AnthonyLaw Before merging, could you adjust the issue to follow this format seen here?

As a rule of thumb, you want to describe these three things:

  • What the current behaviour is.
  • Why this is an issue.
  • How you changed this behaviour.

I know it's a bit overkill for this change, but we want to get in a habit of doing this for each PR/issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants