Fix a bug when files doubled when browsing a folder#181
Open
SergeiVorobyov wants to merge 1 commit intosylikc:masterfrom
Open
Fix a bug when files doubled when browsing a folder#181SergeiVorobyov wants to merge 1 commit intosylikc:masterfrom
SergeiVorobyov wants to merge 1 commit intosylikc:masterfrom
Conversation
Owner
|
I'll review this implementation also a bit later. Last I was looking at this I was thinking about whether this is cleaner than the old static list implementation... It feels similar, but I need to read through the code. I didn't think it was clean before, but I haven't entirely read through this code yet. It looks cleaner though |
SergeiVorobyov
force-pushed
the
issue/147_doubled_files_when_browsing_folder
branch
from
9a61c6c to
9e2b97d
Compare
SergeiVorobyov
force-pushed
the
issue/147_doubled_files_when_browsing_folder
branch
from
9e2b97d to
d098fa8
Compare
Author
|
@sylikc I've updated the PR to recent master. Please consider reviewing it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted this fix from #178 in order to have PRs more granular.