[Security] Scope orphan cleanup to Local Studio-owned processes - #370
Open
fettpl wants to merge 2 commits into
Open
[Security] Scope orphan cleanup to Local Studio-owned processes#370fettpl wants to merge 2 commits into
fettpl wants to merge 2 commits into
Conversation
Author
|
@0xSero, maintainer update: #370 is the narrow current- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make compute cleanup fail closed: Local Studio now signals a native process group or removes a Docker container only after proving that the live target is the exact launch generation recorded by this controller.
This replaces shape-based cleanup authority with durable identity and leaves ambiguous or stale state untouched.
Closes #228
Maintainer alignment
dev(a8d6e6ab5d2e7676a11e3f297883c81464892042).Solution design
Durable ownership records
Native launch proof
ChildProcess; restart recovery remains fail closed when durable OS identity is unavailable.Docker launch proof
Lifecycle behavior
Acceptance criteria
Validation
npm run check— passed.npm run test:integration— passed.dev: 90 to 97 tests, 40.36% to 42.03% functions (+1.67 points), and 51.05% to 52.17% lines (+1.12 points).git diff --check— passed.63b47503a74d13cd3ac0b653044a0572f9c71ef9— no blockers found.Risk and rollout
Fail-closed behavior can leave a genuinely owned orphan running when the host cannot supply enough identity. That residue is intentional and safer than signaling an unrelated workload; the retained record can be reconciled later when ownership becomes provable.
No frontend or packaged desktop behavior changes.