build.ps1: add swift-tools-protocols #85078

owenv · 2025-10-23T04:43:43Z

This will be a sourcekit-lsp dependency starting with swiftlang/sourcekit-lsp#2324, a SwiftPM dependency starting with swiftlang/swift-package-manager#9129, and a swift-build dependency starting with swiftlang/swift-build#782. Update the windows build script accordingly

owenv · 2025-10-23T04:44:21Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-23T16:13:48Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-23T20:09:44Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-23T23:25:36Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

compnerd · 2025-10-24T16:08:43Z

utils/build.ps1

+    -SwiftSDK $SDKROOT `
+    -BuildTargets default `
+    -Defines @{
+      BUILD_SHARED_LIBS = "NO";


Is this a single use library? i.e. does only one product use the library? If not, we should consider the shared version with numbers on the size impact - that is verify that static linking is smaller than the dynamic linking.

It's going to get linked into at least two executables, so I will probably end up flipping it to a shared library but I haven't tested it yet

owenv · 2025-10-24T16:37:07Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-24T21:54:23Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-25T04:51:59Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-25T17:22:55Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-25T21:39:55Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-26T02:27:45Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-26T17:20:18Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-26T21:09:40Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-27T03:53:58Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-27T16:41:10Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-27T20:33:40Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-28T00:15:59Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-28T03:25:21Z

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

owenv · 2025-10-29T04:10:29Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-29T16:19:38Z

C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\sourcekit-lsp\Sources\SKTestSupport\SkipUnless.swift:437:17: error: cannot find 'LocalConnection' in scope

435 |     return try await shared.skipUnlessSupported(allowSkippingInCI: true, file: file, line: line) {

436 |       let server = try await SourceKitLSPServer(

437 |         client: LocalConnection(receiverName: "client"),

    |                 `- error: cannot find 'LocalConnection' in scope

438 |         toolchainRegistry: .forTesting,

439 |         languageServerRegistry: .staticallyKnownServices,

error: fatalError
Error: Error: swift exited with code 1.

owenv · 2025-10-29T16:42:39Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

owenv · 2025-10-29T16:42:48Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-29T22:50:41Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-29T22:50:48Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

utils/build.ps1

owenv · 2025-10-30T03:53:49Z

C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\cli.wxi(167): error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\BuildServerProtocol.dll'. The following paths were checked: T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\BuildServerProtocol.dll [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\asserts\cli.asserts.wixproj]
         C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\cli.wxi(170): error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\LanguageServerProtocol.dll'. The following paths were checked: T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\LanguageServerProtocol.dll [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\asserts\cli.asserts.wixproj]
         C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\cli.wxi(173): error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\LanguageServerProtocolTransport.dll'. The following paths were checked: T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\LanguageServerProtocolTransport.dll [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\asserts\cli.asserts.wixproj]
         C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\cli.wxi(176): error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\SKLogging.dll'. The following paths were checked: T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\SKLogging.dll [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\asserts\cli.asserts.wixproj]
         C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\cli.wxi(179): error WIX0103: Cannot find the File file 'T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\ToolsProtocolsSwiftExtensions.dll'. The following paths were checked: T:\\Program Files\\Swift\\Toolchains\0.0.0+Asserts\usr\bin\ToolsProtocolsSwiftExtensions.dll [C:\Users\swift-ci\jenkins\workspace\swift-PR-build-toolchain-windows\swift-installer-scripts\platforms\Windows\cli\asserts\cli.asserts.wixproj]

hmm, we're still failing to find the dlls when we go to build the installer

owenv · 2025-10-30T04:24:08Z

swiftlang/swift-tools-protocols#15

owenv · 2025-10-30T04:25:29Z

Build complete! (155.78s)
error: abnormal(309): T:\x86_64-unknown-windows-msvc\SourceKitLSPTests\x86_64-unknown-windows-msvc\release\SourceKitLSPPackageTests.xctest --dump-tests-json output:
    

Error: Error: swift exited with code 1.

tests are now building but crashing

owenv · 2025-10-30T05:01:33Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

owenv · 2025-10-30T05:01:41Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-30T21:51:39Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

owenv · 2025-10-30T21:51:47Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-31T03:20:07Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

owenv · 2025-10-31T03:20:15Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-31T03:37:18Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please build toolchain

owenv · 2025-10-31T03:37:25Z

swiftlang/sourcekit-lsp#2324
swiftlang/swift-installer-scripts#474
@swift-ci please smoke test

compnerd · 2025-10-31T04:47:37Z

@swift-ci please build toolchain Windows ARM64 platform

owenv force-pushed the owenv/tools-protocols-windows branch from 2e16a23 to 2857499 Compare October 23, 2025 16:06

compnerd reviewed Oct 24, 2025

View reviewed changes

owenv force-pushed the owenv/tools-protocols-windows branch from 2857499 to 57a58c7 Compare October 24, 2025 16:34

owenv force-pushed the owenv/tools-protocols-windows branch from 57a58c7 to bdcd59d Compare October 26, 2025 02:25

owenv force-pushed the owenv/tools-protocols-windows branch from bdcd59d to a4ac2dc Compare October 26, 2025 17:11

owenv force-pushed the owenv/tools-protocols-windows branch from a4ac2dc to 8876942 Compare October 26, 2025 21:00

owenv force-pushed the owenv/tools-protocols-windows branch from 8876942 to 5d351dd Compare October 27, 2025 03:52

owenv force-pushed the owenv/tools-protocols-windows branch from 5d351dd to 642d724 Compare October 27, 2025 16:17

owenv mentioned this pull request Oct 27, 2025

[SwiftBuild] BSP-based SourceKit-LSP integration swiftlang/swift-package-manager#9289

Open

owenv force-pushed the owenv/tools-protocols-windows branch from 642d724 to 220b235 Compare October 27, 2025 20:20

owenv force-pushed the owenv/tools-protocols-windows branch from 220b235 to 87ea24c Compare October 28, 2025 00:03

owenv mentioned this pull request Oct 28, 2025

Don't specify explicit linkage for CMake targets swiftlang/swift-tools-protocols#13

Merged

owenv force-pushed the owenv/tools-protocols-windows branch from 87ea24c to 1c299c5 Compare October 28, 2025 16:27

owenv force-pushed the owenv/tools-protocols-windows branch 2 times, most recently from f84e347 to a36fe20 Compare October 29, 2025 21:56

compnerd reviewed Oct 29, 2025

View reviewed changes

utils/build.ps1 Outdated Show resolved Hide resolved

owenv force-pushed the owenv/tools-protocols-windows branch 3 times, most recently from da862c6 to 5f253a7 Compare October 30, 2025 04:43

owenv force-pushed the owenv/tools-protocols-windows branch 2 times, most recently from a6399dc to e5ae3c2 Compare October 30, 2025 21:39

owenv mentioned this pull request Oct 30, 2025

Adopt swift-tools-protocols swiftlang/sourcekit-lsp#2324

Open

owenv force-pushed the owenv/tools-protocols-windows branch from e5ae3c2 to c165f77 Compare October 31, 2025 03:05

build.ps1: add swift-tools-protocols

2c58e28

owenv force-pushed the owenv/tools-protocols-windows branch from c165f77 to 2c58e28 Compare October 31, 2025 03:25

build.ps1: add swift-tools-protocols #85078

Are you sure you want to change the base?

build.ps1: add swift-tools-protocols #85078

Conversation

owenv commented Oct 23, 2025

Uh oh!

owenv commented Oct 23, 2025

Uh oh!

owenv commented Oct 23, 2025

Uh oh!

owenv commented Oct 23, 2025

Uh oh!

owenv commented Oct 23, 2025

Uh oh!

compnerd Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

owenv Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

owenv commented Oct 24, 2025

Uh oh!

owenv commented Oct 24, 2025

Uh oh!

owenv commented Oct 25, 2025

Uh oh!

owenv commented Oct 25, 2025

Uh oh!

owenv commented Oct 25, 2025

Uh oh!

owenv commented Oct 26, 2025

Uh oh!

owenv commented Oct 26, 2025

Uh oh!

owenv commented Oct 26, 2025

Uh oh!

owenv commented Oct 27, 2025

Uh oh!

owenv commented Oct 27, 2025

Uh oh!

owenv commented Oct 27, 2025

Uh oh!

owenv commented Oct 28, 2025

Uh oh!

owenv commented Oct 28, 2025

Uh oh!

owenv commented Oct 29, 2025

Uh oh!

owenv commented Oct 29, 2025

Uh oh!

owenv commented Oct 29, 2025

Uh oh!

owenv commented Oct 29, 2025

Uh oh!

owenv commented Oct 29, 2025

Uh oh!

owenv commented Oct 29, 2025

Uh oh!

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 30, 2025

Uh oh!

owenv commented Oct 31, 2025

Uh oh!

owenv commented Oct 31, 2025

Uh oh!

owenv commented Oct 31, 2025

Uh oh!

owenv commented Oct 31, 2025