Add support for generating more C files with Swift Build. #9252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There currently are restrictions on the ability for build plugins to generate C header, modulemap, and APInote files. This removes those restrictions when using Swift Build and adds the output directory for the plugin to the HEADER_SEARCH_PATH for the target.
|
@swift-ci please test |
|
|
||
| // With Swift Build on the horizon, we won't add support for generated headers, modulemaps, and apinotes here | ||
| for absPath in pluginTargetFiles.headers { | ||
| observabilityScope.emit(warning: "Module maps generated by plugins are not supported at this time: \(absPath)") |
There was a problem hiding this comment.
This should say headers
| observabilityScope.emit(warning: "Module maps generated by plugins are not supported at this time: \(absPath)") | ||
| } | ||
| for absPath in pluginTargetFiles.moduleMaps { | ||
| observabilityScope.emit(warning: "API Notes generated by plugins are not supported at this time: \(absPath)") |
There was a problem hiding this comment.
This should say module maps
| if absPath.extension == "swift" || toolsVersion >= .v6_3 { | ||
| files.sources.insert(absPath) | ||
| } else { | ||
| observabilityScope.emit(warning: "Only Swift is supported for generated plugin source files at this time: \(absPath)") |
There was a problem hiding this comment.
"at this time" is weird now; this should instead mention that it's not supported in the current tools version
There was a problem hiding this comment.
Yeah, it's a weird statement. I guess Boris was just trying to give users hope :).
|
@swift-ci please test |
bkhouri
requested changes
Oct 17, 2025
I always do ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently are restrictions on the ability for build plugins to generate C header, modulemap, and APInote files. This removes those restrictions when using Swift Build and adds the output directory for the plugin to the HEADER_SEARCH_PATH for the target.